Gapminder / dollar-street-pages

Dollar Street public pages
https://www.gapminder.org/dollar-street/
GNU General Public License v3.0
14 stars 23 forks source link

CMS. Street dividers. Negative value can be added as street divider value. #1331

Open AntonOlkhovskyi opened 6 years ago

AntonOlkhovskyi commented 6 years ago

Context

User can set negative street divider value, which logically can't be used as a street divider. This leads to the console errors, Poorest label on the street become unreadable.

Steps to reproduce

  1. Navigate to the CMS.
  2. Open Street Settings tab.
  3. In Street dividers input field set negative value (-50 or etc.)
  4. Click green "Plus" icon.

Expected result

Validation error is appear under input field. "Only positive can be used as Street Divider" or similar text should be displayed.

Current result

Negative value is successfully set as Street divider.

street divider values