Hello, this is Shu, a Japanese translator for Factfulness who just got invited to Gapminder Slack.
There's a translation bug for JP language regarding prepositions like "of" or "in". In Japanese, many prepositions like "of" or "in" must be placed after the word instead of before. So instead of "A of B", in Japanese you must do "B {{ 'of' | translate }} A".
I added the logic on LanguageService and used it on the Header component. This might not be the best way (as there are many other places that use {{ 'IN' | translate }}), but at least fixes the header (the most prominent UI) for the Japanese audience.
chibicode
commented
5 years ago
Hello, this is Shu, a Japanese translator for Factfulness who just got invited to Gapminder Slack.
There's a translation bug for JP language regarding prepositions like "of" or "in". In Japanese, many prepositions like "of" or "in" must be placed after the word instead of before. So instead of
"A of B", in Japanese you must do"B {{ 'of' | translate }} A".I added the logic on
LanguageServiceand used it on theHeadercomponent. This might not be the best way (as there are many other places that use{{ 'IN' | translate }}), but at least fixes the header (the most prominent UI) for the Japanese audience.Before (Incorrect)
After (Correct)