search

Gapminder / tools-page

Gapminder tools page vanilla
8 stars 5 forks source link

Unhack this symptomatic fix for color legend #185

Closed angiehjort closed 3 years ago

angiehjort commented 3 years ago

it doesn't work in line chart in the case when not all legend groups are represented by the lines :D

https://github.com/vizabi/vizabi-shared-components/commit/91694d0a492ea64e9ee41fcc3e88bf58eacbfcaf

image

angiehjort commented 3 years ago

Unhack https://github.com/vizabi/vizabi-shared-components/commit/a1083877295caae5c67a15ac86cbf80606c870bd

Proper fix: https://github.com/vizabi/vizabi-reactive/commit/b57444bb68afb8cc6366d691e60344ed8b49a9d8