search

Gapminder / tools-page

Gapminder tools page vanilla
8 stars 5 forks source link

BC: Trail error when bubble has completely no data #195

Closed angiehjort closed 3 years ago

angiehjort commented 3 years ago

Very similar to #190, but different steps to test here

Select Afghanistan Make a trail Set X to Electricity use / person

TypeError: Cannot read property 'getByObjOrStr' of undefined at trail.js:82

this again is the same place where i put protection against min max limits being undefined but then i removed it

jheeffer commented 3 years ago

@angieskazka What is expected behaviour?

Afghanistan being deselected & trailstart removed? Trails being turned off?

jheeffer commented 3 years ago

Fixed in https://github.com/vizabi/vizabi-reactive/commit/d9bba18df30b61430cdad1c3d87a97c566e09240

jheeffer commented 3 years ago

Actually I'll leave it to you to check if it's fixed & close it, Angie.

angiehjort commented 3 years ago

fixed in vizabi-reactive v1.5.0