GarageGames / Torque3D

MIT Licensed Open Source version of Torque 3D from GarageGames
http://torque3d.org
MIT License
3.35k stars 1.2k forks source link

LevelInfo fog vs ScatterSky fog #1948

Open ghost opened 7 years ago

ghost commented 7 years ago

You can set fog color in TheLevelInfo object as well in the ScatterSky object, the fog in the LevelInfoWorks fine until you have a ScatterSky, then the ScatterSky fog color will override the LevelInfo fog color (called fogScale in ScatterSky). This can lead to confusion like this: https://github.com/GarageGames/Torque3D/issues/1043

But my point in this issue is, that it also seems that the ScatterSky fog color is calculated differently, since I saw that copying the values from the LevleInfo fog color into the ScatterSky fog color gave me a vastly different result. I always try to match the fog color the sky/clouds color, so there is a very nice and smooth transition, so I set up a light blue color in the LevelInfo fog, slightly darkened until it perfectly matched the sky/clouds color, then I noticed that the ScatterSky will override it, so I thought I can simply copy the values into the ScatterSky, but the result was that in the ScatterSky was much darker and more saturated as the LevelInfo fog, I had to set it to almost bright white until it had the same color as the slightly darkened light blue. Even a 100% white color in ScatterSky fog is still too dark and too blue for me to match the sky color.

So my question is what is going on there. Possible solutions would be to adapt the ScatterSky fog to the LevelInfo fog or even better remove the fog setting in the ScatterSky since I cannot see the reason why it should be there, but I guess it is probably because of the night settings, since the ScatterSky can have day and night with whole different light and fog setups and so it has to override those values.

ghost commented 7 years ago

Hm I found that the fog color of the ScatterSky is also affected by the skyBrightness setting, so it may not be that bad.