search

GarageGames / Torque3D

MIT Licensed Open Source version of Torque 3D from GarageGames
http://torque3d.org
MIT License
3.35k stars 1.2k forks source link

Reversion: SDL linking against dxerr.lib #2261

Open chaigler opened 6 years ago

chaigler commented 6 years ago

Looks like we had an accidental reversion to #2163. We're back to SDL linking against dxerr.lib.

Areloch commented 6 years ago

Are we? I took a look with a clean devhead pull and don't see any references to dxerr in the cmake file.

chaigler commented 6 years ago

Take a look at Engine/lib/sdl/CMakeLists.txt around line 1307.

To be fair, it's a really minor issue. I think it only crops up if you're building on Windows with DirectX unchecked in cmake. Still, SDL doesn't actually use any of the functions in dxerr so there's no need to link it at all (which is what this was talking about: https://github.com/davidsiaw/SDL2/issues/1)

Areloch commented 6 years ago

Add, dang ok I didn't realize it was in the SDL CMakeLists. Good spot.