Clang "cannot pass object of non-trivial type 'String' through variadic function"

jmdejong commented 5 years ago

The build errors in the compiling when using Clang.

See https://travis-ci.com/GarageGames/Torque3D/jobs/168138067#L3417

/home/travis/build/GarageGames/Torque3D/Engine/source/gui/worldEditor/guiConvexShapeEditorCtrl.cpp:181:107: fatal error: 
    cannot pass object of non-trivial type 'String' through variadic function;
    call will abort at runtime [-Wnon-pod-varargs]
...- No such class: %s", mProxyObjects[i].targetObjectClass);

Gcc does not have this problem (I have not yet checked whether this would generate a warning).

Azaezel commented 5 years ago

that'll get fixed with https://github.com/GarageGames/Torque3D/pull/2287/files#diff-3e01e82641e6977602cf441de9acb19dL180

jmdejong commented 5 years ago

Awesome! Can confirm that that indeed fixes it

GarageGames / Torque3D

Clang "cannot pass object of non-trivial type 'String' through variadic function" #2291