search

Garanas / BrewWikiGen

A wiki generator for Forged alliance unit mods.
0 stars 0 forks source link

Damage per second calculations are different from those in-game #3

Open Garanas opened 6 months ago

Garanas commented 6 months ago

The question is now: which one is right 🤠 !

lL1l1 commented 6 months ago

The in-game ones used in unitviewdetail are correct because they simulate the firing cycle directly.

https://github.com/FAForever/fa/blob/256ea456663bc72aa2f9fc294d2baeae9d8b8767/lua/ui/game/unitviewDetail.lua#L564-L665

Garanas commented 6 months ago

Then we have three places - during blueprint loading, in the unit view detail and the one in the wiki. We should standardize that 😄

lL1l1 commented 6 months ago

There's also unit tooltips in the unit manager which use the ui/lobby/UnitsAnalyzer.lua file, so we can look at moving some blueprint analysis functions out of there into a shared/ file for use by all lua and a format easily transferable over to the wiki.

Garanas commented 6 months ago

That sounds like a great idea. The shared folder in general should be loadable by the wiki generator.