GarboMuffin / nicehash-calculator-web

A website that estimates the profitability of buying hashing power on NiceHash
MIT License
16 stars 16 forks source link

Profit maybe too high #7

Closed Qwertzi01 closed 6 years ago

Qwertzi01 commented 6 years ago

Hi, create work but I think for example by coin Decred the profit is to high - 0.0010 BTC. I calculated for my own with 1.5 TH for 12 hours and I get (with divided fees of 0.000336 BTC) an profit around 0.0003 BTC. Based on 0.0105 BTC/TH/day and 24h average difficulty. I'm wrong? Kind regards. Qwertzi

ghost commented 6 years ago

The estimations on this don't account for any of the fees of NiceHash (0.0001 BTC + 3%), pools (typically ~1%), or exchanges (1-3% or something). I've heard in the past that whattomine.com (this api used in this project) also tends to overestimate profits but I can't confirm this.

What pool were you using? If your pool had bad luck that can kill any chances of profit.

These numbers are also updated every two hours (I intend to reduce this) and this market tends to have very wild swings all the time.

ghost commented 6 years ago

I think I may have misunderstood what you're saying and I'd like to add a few more things:

It determines revenue from the What To Mine API. Without going into too much detail it typically gets revenue data from a route like http://whattomine.com/coins/152.json?hr=1000000 (btc_revenue tag) but for coins that are popular it can come from https://whattomine.com/coins.json (btc_revenue24 tag in each coin with some extrapolation)

The actual code that does the revenue calculations lives in https://github.com/GarboMuffin/nicehash-calculator/tree/33890e9e44b9c281e0e60c34ea9f8533b6bf7aa5. Perhaps you can find some more useful things in there.

I do think that swings in hashrate, difficulty, and price do make any estimations very inaccurate.

Qwertzi01 commented 6 years ago

Thanks for the fast feedback. And yes I use also WhatToMine/MyCryptoBuddy but only for calculating the Est. Rewards for 1 hour and this only in original coin like Decred (with the 24h average diff.).

This data I use in my own calculations with excel. For the test yesterday I used your 0.0105 BTC/TH/day for Decred.

If you want I can mail you my excel sheet and you can take a look at it!? To understand the calculations in your code I should first learn coding. ;-)

By the way you are right - WhatToMine has slightly higher est. rewards and to high est. rewards in btc because of Exchange rate is often to good/high. I prefer MyCryptoBuddy with the estimated 24h difficulty from whattomine.

Qwertzi01 commented 6 years ago

What pool were you using? If your pool had bad luck that can kill any chances of profit.

Yesterday I was so confused by the large difference (0.0007 BTC) between your and my result.

So I made no shot with nicehash yesterday. I want use pool's like unimining.net for GBX and decredpool.org for DCR. I'm relative new with selling hashpower on NH and try to make little profit.

Exchanges for less popular coins like GBX/DCR also have a very high fee for withdrawals after exchange (from 0.0005 BTC upwards). Thats killing often my profit calcs for Decred and GoByte.

Qwertzi01 commented 6 years ago

WhatToMine itself calculate less Revenue / Rewards for example GoByte today now ... 0.1789 BTC/GH/day (Last updated: 17.3.2018, 07:57:13) vs. 0.1357 BTC/GH/day (whattomine)

unbenannt unbenannt2

What do you think?

ghost commented 6 years ago

ok yeah looks like some coins are fucked up, i'm looking into it now.

ghost commented 6 years ago

website is saying 0.1807 BTC, What To Mine is saying 0.13973734 BTC... have you noticed this with any other coins? I think there may be a larger problem than just one coin.

ghost commented 6 years ago

Once it updates again it should be fixed. I'll force it to make an update in a little bit. If it still happens just reopen the issue.

ghost commented 6 years ago

It should be fixed now.

pic