Garden-AI / garden

https://garden-ai.readthedocs.io
MIT License
20 stars 4 forks source link

first pass refactor `garden-ai prototype` commands/interface #306

Closed OwenPriceSkelly closed 1 year ago

OwenPriceSkelly commented 1 year ago

Scope of this ticket is a little loose but primarily focused on early quality of life improvements to the interface we want to prioritize for the sake of the development process

Broad strokes:

isaac-darling commented 1 year ago

There are a couple of things here that I am unsure about. For instance, an image being "reused" later can mean two things:

a. The notebook hasn't changed, in which case, why would the CLI be pointed at it again? b. The notebook has changed, in which case, the container must NOT be reused because it will not reflect those changes.

Of course if I misinterpreted you somewhere, please let me know!

OwenPriceSkelly commented 1 year ago

Ah yeah sorry this issue is really just what I had jotted down after a huddle the other day, so its pretty provisional and missing some context.

The bit about reuse was thinking more about editing/developing the notebook before finalizing it with the plant/finalize/publish step (e.g. if I copy a my_model_definition.py file over when I make the notebook, maybe I shouldn't need to explicitly copy it every time I want to spin up that notebook's container)

the answer to a) though is debugging -- a notebook that worked fine before planting/publishing doesn't work when I try running it on an endpoint. we decided that dropping someone who thought they were debugging a notebook into a vanilla python repl is probably not the way to go, but we also don't want to put them in a context that diverges too far from what the endpoint actually sees. the dream would be like the same notebook but it spits you out in a new cell at the bottom, and all the others are grayed out in favor of a load_session, maybe? very much still noodling with it

isaac-darling commented 1 year ago

Ah, that makes a lot of sense and would be pretty easy to put together given the utility for notebooks that has already been written in various parts of the CLI! I look forward to the advances in user-friendliness!

WillEngler commented 1 year ago

Superseded by more specific tickets