search

Garden-AI / garden

https://garden-ai.readthedocs.io
MIT License
18 stars 4 forks source link

If your disk is full, attempted Docker pulls via Garden give you a misleading error #351

Open WillEngler opened 10 months ago

WillEngler commented 10 months ago

I was playing around on an EC2 instance that had a small-ish volume attached (20GB). I was going and testing all our TensorFlow images. Eventually the disk got close to full. When I initiated a pull that would have exceeded my disk space I saw ...

ImageNotFound: 404 Client Error for
http+docker://localhost/v1.43/images/gardenai/base:python-3.11-jupyter-tf/json: Not Found

So it seems like the pull failed, and then the image wasn't available locally, and the Docker client (and by proxy Garden) reports that as a 404, which is misleading.

Assumptions:

1. 2.

Acceptance Criteria

Given..., when..., then...

OwenPriceSkelly commented 9 months ago

similarly unhelpful/misleading error when docker just isn't running we could also handle more gracefully: 

DockerException: Error while fetching server API version: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))