codecov-commenter
commented
8 months ago Codecov Report
Attention: 18 lines in your changes are missing coverage. Please review.
Comparison is base (
3308a3b) 76.38% compared to head (440add8) 76.32%.
| Files | Patch % | Lines |
|---|---|---|
| garden_ai/client.py | 18.18% | 9 Missing :warning: |
| garden_ai/backend_client.py | 41.66% | 7 Missing :warning: |
| garden_ai/app/notebook.py | 33.33% | 2 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #371 +/- ## ========================================== - Coverage 76.38% 76.32% -0.07% ========================================== Files 42 42 Lines 2291 2306 +15 ========================================== + Hits 1750 1760 +10 - Misses 541 546 +5 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes #355
Overview
This PR integrates with the new backend endpoint that grants temporary credentials for pushes to a Garden ECR repo. It uses those credentials to authenticate with ECR, so now users don't need to set up a DockerHub account themselves to publish with Garden.
Discussion
Maybe we'll want a hidden --image-repo option for power users at some point, but for now I think it made sense to just rip it out. We can add it back if we need it.
Testing
I tested in the dev env with the sklearn seedling. I confirmed the flow was working end to end, all the way to River.
Documentation
I purged mentions of needing DockerHub and the --repo flag from the docs.
📚 Documentation preview 📚: https://garden-ai--371.org.readthedocs.build/en/371/