search

Garden-AI / garden

https://garden-ai.readthedocs.io
MIT License
17 stars 4 forks source link

Replace AuthClient with new AuthLoginClient #387

Closed MaxTuecke closed 8 months ago

MaxTuecke commented 8 months ago

Fixes #385

Overview

The Globus SDK released with v3.29.0 some changes to AuthClient. AuthClient no longer includes methods for OAuth 2 login flows, which are now valid calls for the new AuthLoginClient subclasses. Now AuthClient is the only class that provides functionality for accessing Globus Auth APIs, while AuthLoginClient is meant for the NativeApp login.

The fix for Garden was just to swap out AuthClient references with the new AuthLoginClient.

Bumped globus_sdk version from ">=3.12.0,<=3.27.0" to "^3.34.0".

Testing

Fixed unit tests to mock AuthLoginClient instead of AuthClient.

📚 Documentation preview 📚: https://garden-ai--387.org.readthedocs.build/en/387/

WillEngler commented 8 months ago

LGTM, thanks for knocking this out Max!