Garden-AI / garden

https://garden-ai.readthedocs.io
MIT License
17 stars 4 forks source link

You can't install mastml and pin dill to 0.3.5.1 in requirements.txt. `notebook start` will fail with a confusing error message #394

Open WillEngler opened 7 months ago

WillEngler commented 7 months ago

How to reproduce:

The requirements will install and things will seem to be going ok. Then as installation is wrapping up you'll see:

---> 380d58af7bb9
Successfully built 380d58af7bb9
Notebook started! Opening http://127.0.0.1:8888/notebooks/asr_entrypoint.ipynb?token=791fb91ea2175a1bbf15e1c9606930ebdf6c5fe6a0c3d5bd in your default browser (you may need to refresh the page)

{stack trace that points to line 200 of notebook.py}

NotFound: 404 Client Error for
http+docker://localhost/v1.43/containers/6902c4c9f412a746bf278833b285254508b2f22ef133e42b9a39
d6a399bdbd90/json: Not Found ("No such container:
6902c4c9f412a746bf278833b285254508b2f22ef133e42b9a39d6a399bdbd90")

It seems like this isn't just about version mismatches. For example, garen-ai requires boto3 ^1.29. But this requirements.txt builds fine.

garden-ai
boto3==1.28

I don't know exactly what's happening here. We know mastml gives us issues because it has dlhub as a dependency. But this is probably a more general class of issue that would be good to handle gracefully.

Assumptions:

1. 2.

Acceptance Criteria

Given..., when..., then...

WillEngler commented 7 months ago

This also repros with a requirements.txt of

mastml
scikit-learn==1.1.3