search

Garden-AI / garden

https://garden-ai.readthedocs.io
MIT License
16 stars 4 forks source link

Quick fix: get correct traceback line in build errors #406

Closed WillEngler closed 5 months ago

WillEngler commented 5 months ago

Overview

Owen's container handling improvements in the docker prune PR means there's now an extra line in build log output in the case of a build failure. The last line is something like "Removing intermediate container 33cb4f87eb1e". This PR updates some error handling code to reflect this.

Discussion

Yeah, I know this is fragile ... If it breaks again let's reconsider.

Testing

Tested manually

Documentation

No

📚 Documentation preview 📚: https://garden-ai--406.org.readthedocs.build/en/406/

codecov-commenter commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0f2a137) 75.59% compared to head (d5d7488) 75.59%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #406 +/- ## ======================================= Coverage 75.59% 75.59% ======================================= Files 45 45 Lines 2749 2749 ======================================= Hits 2078 2078 Misses 671 671 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.