Garden-AI / garden

https://garden-ai.readthedocs.io
MIT License
16 stars 4 forks source link

Edit entrypoint and garden metadata from the command line #432

Closed WillEngler closed 4 months ago

WillEngler commented 4 months ago

Closes #386

Overview

Adds new entrypoint edit and garden edit commands.

Discussion

I'm deliberately making this pretty quick and dirty to avoid overbuilding this before we make an app and make this obsolete. For example, here's the view after you enter the command

Screenshot 2024-03-04 at 11 40 17 AM

You pick a field with an arrow key and enter, then click OK and you can edit the field. Having to click OK is janky, but (surprisingly) removing the need to click OK would be a step up in complexity to implement. This should solve the problem in the short term, even if it isn't beautiful.

Testing

I tested both commands manually

Documentation

Just in the CLI help


📚 Documentation preview 📚: https://garden-ai--432.org.readthedocs.build/en/432/

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 27.08333% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 75.69%. Comparing base (e7fe81d) to head (50f16cd).

Files Patch % Lines
garden_ai/utils/interactive_cli.py 28.00% 18 Missing :warning:
garden_ai/app/entrypoint.py 25.00% 9 Missing :warning:
garden_ai/app/garden.py 27.27% 8 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #432 +/- ## ========================================== - Coverage 76.44% 75.69% -0.76% ========================================== Files 49 50 +1 Lines 3091 3139 +48 ========================================== + Hits 2363 2376 +13 - Misses 728 763 +35 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

WillEngler commented 4 months ago

Thanks for the feedback. I'll incorporate those suggestions and then pull this in.