search

Garden-AI / garden

https://garden-ai.readthedocs.io
MIT License
16 stars 4 forks source link

428 reference new endpoint #434

Closed OwenPriceSkelly closed 4 months ago

OwenPriceSkelly commented 4 months ago

closes #428

Overview

This wraps up the demo-endpoint-related changes to the SDK and has the final (for the foreseeable future) tweaks to the helm chart.

Discussion

Changes to the workerInit for the demo endpoint have been live since last week -- this is the kludge for running models with python <= 3.7 which I hope to never touch again. I also added a 20 minute task timeout, which should be generous enough for good faith demos but not like, mining bitcoin or whatever.

The docs now point tutorial-followers to join the Garden Users group as both a prerequisite and again at the point where users are going to try running on the demo endpoint.

The special error handling is there so users who bravely don't read docs still have an easy way to join.

still TODO: configure the globus group to auto-accept members instead of (only occasionally?) requiring me to manually approve them, but nothing in this PR is blocked on that.

Testing

I tested this with DLHub models (to make sure they remained unbroken) and by logging in with my personal email so I could confirm that the error handling looked correct for group non-members.

Documentation

Yes, just in the tutorial

📚 Documentation preview 📚: https://garden-ai--434.org.readthedocs.build/en/434/

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 75.51%. Comparing base (3b59ca2) to head (47d0275).

Files Patch % Lines
garden_ai/entrypoints.py 52.63% 9 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #434 +/- ## ========================================== - Coverage 75.69% 75.51% -0.18% ========================================== Files 50 50 Lines 3139 3149 +10 ========================================== + Hits 2376 2378 +2 - Misses 763 771 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.