codecov-commenter
commented
4 months ago Codecov Report
Attention: Patch coverage is 22.22222% with 7 lines in your changes are missing coverage. Please review.
Project coverage is 75.42%. Comparing base (
3fc4591) to head (4eafc12).
| Files | Patch % | Lines |
|---|---|---|
| garden_ai/scripts/save_session_and_metadata.py | 22.22% | 7 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #441 +/- ## ========================================== - Coverage 75.51% 75.42% -0.09% ========================================== Files 50 50 Lines 3149 3154 +5 ========================================== + Hits 2378 2379 +1 - Misses 771 775 +4 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
(hopefully) fixes #436
Overview
This relaxes our dill constraints to exactly the same as globus compute. Because we end up installing globus compute after garden anyways (in the endpoint's workerInit), I don't actually think our aggressive pinning strategy was actually doing anything as of upgrading the endpoint.
I also learned that the version we'd been pinning, dill==0.3.5.1, never supported 3.11 (oops), so I don't think it's even currently possible to publish an image running python 3.11 (dill breaks on the save_session call when I try).
Discussion
see #440 -- I'm not sure if this is going to be enough to get images running 3.11 working unless that bug really did have to do with github-related installs. Still, we don't lose any functionality we hadn't already broken by relaxing the constraint here.
the cryptography de-bump is related to #439
Testing
manually, by publishing dummy notebooks with entrypoints that just report the version of dill currently installed. I also made sure I was installing garden from my branch instead of pypi inside of the container.
📚 Documentation preview 📚: https://garden-ai--441.org.readthedocs.build/en/441/