codecov-commenter
commented
4 months ago Codecov Report
Attention: Patch coverage is 64.51613% with 11 lines in your changes are missing coverage. Please review.
Project coverage is 75.36%. Comparing base (
a9da8e0) to head (fdfb242).
| Files | Patch % | Lines |
|---|---|---|
| garden_ai/app/notebook.py | 0.00% | 6 Missing :warning: |
| garden_ai/containers.py | 75.00% | 5 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #444 +/- ## ========================================== - Coverage 75.42% 75.36% -0.07% ========================================== Files 50 50 Lines 3154 3182 +28 ========================================== + Hits 2379 2398 +19 - Misses 775 784 +9 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Closes #395
Overview
This PR makes it so the default port we open Jupyter on is less popular and less likely to have conflicts. (9188 instead of 8888.) And then if 9188 is in use we try 9189, 9190, and so on until we give up at 9198. This makes it so that users can have multiple Jupyter sessions open at a time. It also means that a user running Jupyter on a default port in a standalone application can use Garden without shutting down their other notebook
Discussion
Testing
I updated an affected unit test. I also tested manually on cases where I opened multiple instances of Jupyter in multiple terminal windows.
Documentation
I updated some docs that referenced the old default port.
📚 Documentation preview 📚: https://garden-ai--444.org.readthedocs.build/en/444/