Garden-AI / garden

https://garden-ai.readthedocs.io
MIT License
19 stars 4 forks source link

bug: GitHubConnector doesn't play nicely with git-lfs #447

Closed OwenPriceSkelly closed 4 months ago

OwenPriceSkelly commented 6 months ago

If I have a large model that I've hosted on GitHub using git-lfs, the GitHubConnector only clones the placeholder file instead of the actual large file.

This is because the base images don't have the git-lfs extension installed by default.

~TODO: If the huggingface connector "just works" here without the extra dependency, we should maybe just nudge users to host on huggingface instead of github.~

~Otherwise, if both connectors have this secret dependency, we need to rebuild the images with RUN curl -s https://packagecloud.io/install/repositories/github/git-lfs/script.deb.sh | bash && apt-get install git-lfs~

Update: huggingface connector indeed doesn't need this.

Acceptance Criteria: