Garden-AI / garden

https://garden-ai.readthedocs.io
MIT License
16 stars 4 forks source link

model connectors should pin an exact commit as their revision #455

Closed OwenPriceSkelly closed 1 month ago

OwenPriceSkelly commented 2 months ago

Possibly part of #422 and/or #454

Currently, both model connectors accept an optional revision* argument. Even if one isn't provided explicitly, we should infer the exact commit hash and track it in the connector's ModelMetadata.model_version.

Moreover, we should use that exact hash in the respective stage() methods, so that the exact same model is downloaded every time the entrypoint is run, even if new commits are added to the branch it's pointed at.

* GitHubConnector calls it branch