Closed hholb closed 6 months ago
Attention: Patch coverage is 89.70588%
with 7 lines
in your changes are missing coverage. Please review.
Project coverage is 75.94%. Comparing base (
cd758d8
) to head (45ebff4
).
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
resolves #455
Related: #454
Overview
Both
HFConnector
andGitHubConnector
now attempt to retrieve a commit hash from their remote repos and store it in their ModelMetadata.model_version when instantiated. If no commmit hash is found, aConnectorInvalidRevisionError
is raised.The pinned commit hash is then used when
stage()
is called to pull down the same model each time the entrypoint is run.Discussion
In
GitHubConnector
I am using the github api to get the commit info. This only works with public repos.Testing
New unit tests in
tests/test_models.py
confirm the commit hash is correctly stored and used withinstage()
.Documentation
No documentation updated.
📚 Documentation preview 📚: https://garden-ai--464.org.readthedocs.build/en/464/