Closed hholb closed 1 month ago
Attention: Patch coverage is 15.00000%
with 17 lines
in your changes are missing coverage. Please review.
Project coverage is 76.31%. Comparing base (
d30a2b7
) to head (c8a6be0
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
garden_ai/scripts/save_session_and_metadata.py | 11.11% | 16 Missing :warning: |
garden_ai/app/garden.py | 0.00% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Resolves #375
Overview
Pin requirements in the
RegisteredEntrypoint
metadata if a requirements file is present when a notebook is published.Write the requirements into
metadata.json
inside the published container image. This ensures when a garden is published to the search index the metadata for each entrypoint includes the requirements.Fix a small bug where creating a garden with no contributors threw an exception.
add flake8 to pre-commit
add emacs TAGS to
.gitignore
Testing
Tested manually by creating a notebook with a requirements file and a single entrypoint, publishing it, and confirming that the
metadata.json
in the published image contains the requirements data. Tested another notebook with no added requirements to ensure other functionality is not impacted.I am struggling to come up with efficient unit tests for this. I want to confirm the
metadata.json
is correct, but to do that I need to build a container image which will significantly slow down the test suite.Documentation
Updates the doc comments for
RegisteredEntrypoint
📚 Documentation preview 📚: https://garden-ai--470.org.readthedocs.build/en/470/