Closed OwenPriceSkelly closed 3 months ago
Attention: Patch coverage is 0.58366%
with 511 lines
in your changes missing coverage. Please review.
Project coverage is 0.13%. Comparing base (
6236bd9
) to head (db7ba36
). Report is 18 commits behind head on main.
:exclamation: There is a different number of reports uploaded between BASE (6236bd9) and HEAD (db7ba36). Click for more details.
HEAD has 2 uploads less than BASE
| Flag | BASE (6236bd9) | HEAD (db7ba36) | |------|------|------| ||4|2|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:red_square: :red_square: :red_square: THAT DIFF :red_square: :red_square: :red_square:
closes #504 and closes #506
Overview
This was a pretty big refactor and rethinks the design of our core
Garden
andEntrypoint
classes. I lost my original writeup to a poorly-timed browser refresh, so I synced with @WillEngler earlier talked him through the major changes.To summarize for bookkeeping:
schemas
submodule, and are only responsible for validating data entering or exiting the system. These areEntrypointMetadata
,RegisteredEntrypointMetadata
, andGardenMetadata
. The latter two correspond closely to the respective backend schemasGarden
andEntrypoint
are responsible for things like__call__
,__dir__
,_repr_html_
etc that allow users to invoke entrypoints from a garden like methods. these have ametadata
attribute containing exactly one respective*Metadata
object, which is required to instantiate.This PR also declares unit test bankruptcy, but we have test czar @hholb to bail us out in #507 and #511.
📚 Documentation preview 📚: https://garden-ai--508.org.readthedocs.build/en/508/