search

Garee / pytodoist

Use Todoist with Python ✅
https://pytodoist.readthedocs.org/
MIT License
165 stars 33 forks source link

Completing recurring task terminates task #13

Closed MartinBernstorff closed 7 years ago

MartinBernstorff commented 7 years ago

Hi Garee! Thanks a lot for this!

According to the todoist API, recurring tasks are a special case.

The complete function terminates the recurring task.

Is it possible for this behaviour to be changed? 👍

Garee commented 7 years ago

Thanks for letting me know about this special case. The Todoist API has changed since my initial implementation.

I have created v2.0.5 that contains the necessary change. Please upgrade:

$ pip install --upgrade pytodoist

MartinBernstorff commented 7 years ago

Thanks a lot Gary! I'm seriously impressed by your turn-around time.

Do you plan to update pytodoist for the todoist API v7?

I don't want to implement pytodoist into too many scripts in case Todoist abandons v6 😄

Garee commented 7 years ago

I have unit tests for the current functionality so I'm confident that any changes that were made to the API do not break compatibility. It's likely that there are a few new API calls that I haven't added to PyTodoist - I'll go through the documentation later.

What I meant was that particular complete call had changed to introduce the special case. It looks like the others are exactly the same.

If you spot any issues let me know :)

MartinBernstorff commented 7 years ago

Glad to hear it! Thanks again 👍