_getRemoteData doesn't always check all the possible ways to download the source file.

GaretJax / phpbrowscap

Standalone replacement for php's native get_browser() function

MIT License

429 stars 69 forks source link

_getRemoteData doesn't always check all the possible ways to download the source file. #38

Open quentin389 opened 11 years ago

quentin389 commented 11 years ago

The logic in _getRemoteData() is faulty. No matter which update style I choose all the update methods should be checked if my chosen way fails. Either that or NONE (an option should be added).

There is a nice _getUpdateMethod() method which can be used to fix this mess along with https://github.com/GaretJax/phpbrowscap/pull/15 issue.