search

GaretJax / phpbrowscap

Standalone replacement for php's native get_browser() function
MIT License
429 stars 69 forks source link

Change namespace Exception name. #39

Open quentin389 opened 11 years ago

quentin389 commented 11 years ago

I don't wanna know who wrote that code:

use \Exception as BaseException;
class Exception extends BaseException
{}

but that's some really terrible piece of code.

I'm gonna change the in-namespace exception to something like BrowscapException, and update all the throws. That can break someones code, but tbh it's a fair price for not keeping this monster alive.

ntvsx193 commented 11 years ago

Pull request https://github.com/GaretJax/phpbrowscap/pull/42