GaretJax / phpbrowscap

Standalone replacement for php's native get_browser() function
MIT License
429 stars 69 forks source link

Version property public readable #57

Closed dwight66 closed 10 years ago

dwight66 commented 10 years ago

Can you make the 'const VERSION' property public accessible? I would like to use your phpbrowscap as an unmodified library into my code. Making this property public enables me to test if the minimum version of phpbrowscap is being used.

quentin389 commented 10 years ago

It's a constant. It IS publicly readable, as any other constant in PHP.

http://www.php.net/manual/pl/language.oop5.constants.php

dwight66 commented 10 years ago

Thank you for your reaction. You are right. (of course, you wrote it :-) ) I found a way to get its version number. It was not there where I expected it. (Lack to php experience, I presume...). I'm used to instantiate a class and then read a porperty from the instance. However in the instance I couldn't find the version property, so I suspected the property to be hidden. (The property has not an access modifier, so I presumed it was 'private'.) By reading it directly from the class with 'Browscap::VERSION' I was able to get the version. Thank you also for creating browscap. I hope you 'll keep it up for a long time.

On Tue, Mar 11, 2014 at 11:40 AM, quentin389 notifications@github.comwrote:

It's a constant. It IS publicly readable, as any other constant in PHP.

http://www.php.net/manual/pl/language.oop5.constants.php

Reply to this email directly or view it on GitHubhttps://github.com/GaretJax/phpbrowscap/issues/57#issuecomment-37282274 .