curl update method has no proxy settings and forcing update name by user is not validated

GaretJax / phpbrowscap

Standalone replacement for php's native get_browser() function

MIT License

429 stars 69 forks source link

Open mlukaszewski opened 10 years ago

mlukaszewski commented 10 years ago

curl option can and have to use proxy settings too.

second case is if user force update method there is no validation of choosen option.

I'll write patch

mimmi20 commented 10 years ago

Please look at issue #38 and PR #53 for your second case. If you are readycould you submit your changes also to https://github.com/browscap/browscap-php ?

mlukaszewski commented 10 years ago

I'm ready. I'll submit today :)