feature: download the compo folder as an archive

Gargaj / wuhu

Lightweight Party Management System

http://wuhu.function.hu/

Other

41 stars 26 forks source link

feature: download the compo folder as an archive #69

Closed 0b5vr closed 1 year ago

0b5vr commented 1 year ago

because the folder layout is perfect for compo setup

it needs php-zip to work

Points need review

[ ] How do you think about this feature?
[ ] It saves a zip archive directly below the /var/www/entries_private . Is it valid?
[ ] Is the implementation and placement of zip_dir appropriate?
[ ] Is the endpoint http://localhost:8081/compos.php?download=1 appropriate?
[ ] My English sucks. correct me if it's wrong

Gargaj commented 1 year ago

Why is it downloading the whole folder and not just the selected files?

0b5vr commented 1 year ago

The directory structure inside the entries_private/<compo> is very useful to operate compos!, since it's separated by directories with an entry number. it's how we operate compos even before the wuhu era.

Gargaj commented 1 year ago

But for internal use, isn't downloading just directly from the server simpler?

0b5vr commented 1 year ago

But for internal use, isn't downloading just directly from the server simpler?

True, but we couldn't do that in TDF2021 since we didn't have access to the filesystem of the server. We've used a cloud without SSH or FTP (*1), I know it is completely opposite from your design philosophy though :sweat_smile:

It would be good for orgas that do not have access to the server anyway. In our cases, a person who manages the wuhu server is different from compo masters.

*1: I don't know the exact situation about that, it was falken-san who managed the server

Gargaj commented 1 year ago

Honestly this might be one of those cases where banishing this functionality into a plugin might be more appropriate, then.

0b5vr commented 1 year ago

mhm! I'll try packing the feature into a plugin

0b5vr commented 1 year ago

Made it a plugin! does it look good?