GarinZ / link-map

Tree style tab mananger for Chrome and Edge, Tabs Outliner alternative
https://linkmap.cc
GNU Affero General Public License v3.0
265 stars 29 forks source link

The save and close button is not working properly #60

Open cablop opened 1 year ago

cablop commented 1 year ago

Description

The save and close button is not working properly, it marks the node (and subnodes, if window or collapsed) as closed, but they never close. image

Steps to reproduce (if applicable)

Open a window, a new window with default tab works, click on the save and close button.

Expected behavior

Node (and subnodes, if window or collapsed) gets marked as closed AND they are closed after that.

Actual behavior

Node (and subnodes, if window or collapsed) gets marked as closed, but node (window or tab) remains open.

Screenshots (if applicable)

Before clicking: image

After clicking: image

neiljdo commented 1 year ago

I experience this, too. Also if you try opening the closed node via double-clicking, a new tab gets opened instead.

Direction29th commented 1 year ago

I experience this, too.

lrq3000 commented 1 year ago

Same issue here. In practice, we can just close the node (ie, tab or window) as a workaround, because it indeed gets saved, and closing it manually does not remove it from Link Map, but still it would be better if the node could also get closed.

Direction29th commented 1 year ago

Same issue here. In practice, we can just close the node (ie, tab or window) as a workaround, because it indeed gets saved, and closing it manually does not remove it from Link Map, but still it would be better if the node could also get closed.

sure,or you can reboot the plugin to fix this bug. However the bug will happen again after no long time.

dveb8886 commented 1 year ago

I'm seeing this too, and it impacts the use-case of using the outliner as a bookmarker

lrq3000 commented 1 year ago

No it doesn't prevent using LinkMap for bookmarking because it does save the tabs and windows, it just does not close them, but you can and they will stay saved if you stashed them beforehand in LinkMap.

7 oct. 2023 17:51:00 dveb8886 @.***>:

I'm seeing this too, and it impacts the use-case of using the outliner as a bookmarker

— Reply to this email directly, view it on GitHub[https://github.com/GarinZ/link-map/issues/60#issuecomment-1751743272], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAIRFXX7NTP6P2LLEZ6THX3X6F26JAVCNFSM6AAAAAAZVFSDY6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRG42DGMRXGI]. You are receiving this because you commented. [Image de pistage][https://github.com/notifications/beacon/AAIRFXR466Y3VWDR2BKBPTDX6F26JA5CNFSM6AAAAAAZVFSDY6WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTINF5SQ.gif]

kachunkachunk commented 1 year ago

To work around this issue, I've been resorting to closing and reopening the Link Map window. MS Edge here.