search

Garrafao / durel_system_annotators

3 stars 0 forks source link

Re-factor and simplify #16

Closed Garrafao closed 9 months ago

Garrafao commented 10 months ago

Many dependencies are introduced by the binary XLMR annotator. We don't need this one anymore. Hence, we should remove it and all its dependencies and considerably simplify and re-factor input and output format.

Garrafao commented 9 months ago

@AinaIanemahy Running python ./tests/integration/test_random_annotate.py currently gives this: ModuleNotFoundError: No module named 'random_annotate'. Do we want to keep the random annotator?

Garrafao commented 9 months ago

With commit 313dd58 python ./tests/integration/test_xl_lexeme_annotate.py is running after re-factoring.

AinaIanemahy commented 9 months ago

@AinaIanemahy Running python ./tests/integration/test_random_annotate.py currently gives this: ModuleNotFoundError: No module named 'random_annotate'. Do we want to keep the random annotator?

@Garrafao I would keep the random annotator. I have added the random_annotate.py script in the most recent commit. 031fa97

Garrafao commented 9 months ago

@AinaIanemahy Running python ./tests/integration/test_random_annotate.py currently gives this: ModuleNotFoundError: No module named 'random_annotate'. Do we want to keep the random annotator?

@Garrafao I would keep the random annotator. I have added the random_annotate.py script in the most recent commit. 031fa97

As far as I understand random annotation is now done in annotate.py. In contrast to what I said in the meeting, I now think that it can stay there.

Garrafao commented 9 months ago

With commit 00e6f70 unnecessary dependencies, scripts and imports have been removed. As far as I remember we do not plan to re-factor the input and output formats.