search

Garrafao / durel_system_annotators

3 stars 0 forks source link

Implement split in data.py #47

Closed AinaIanemahy closed 6 months ago

AinaIanemahy commented 7 months ago

After deleting annotation_provider.py (#43 ), data.py now outputs a file "instances.csv" in each data set folder with the structure described above. Note that currently we do not have data_split/ so all tests have to be run on the full data sets.

We should note whether the split should be implemented again. Otherwise this issue should be closed as not planned.

Garrafao commented 7 months ago

@shafqatvirk Is this currently needed from your side?

shafqatvirk commented 6 months ago

@shafqatvirk Is this currently needed from your side?

I have run all the integration test recently, and did not find any issue. So, i think, it is safe to close this issue.

Garrafao commented 6 months ago

closed as not planned.