search

Garrett-Bodley / SHAlala

Turn Your SHA1 into Music If You Want to Do That For Some Reason
https://garrett-bodley.github.io/SHAlala/
4 stars 1 forks source link

COULD WE PLEASE PLEASE PLEASE PLEASE HAVE INSTRUMENTS #22

Closed gregsadetsky closed 6 months ago

gregsadetsky commented 7 months ago

https://nbrosowsky.github.io/tonejs-instruments/

https://nbrosowsky.github.io/tonejs-instruments/demo.html

!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

Garrett-Bodley commented 7 months ago

this is incredible must have thank youuuu

Garrett-Bodley commented 7 months ago

Current build uses piano and bass! Want to migrate to React fully before adding a full "select your instrument" field. McCoy Tyner mode sounds much better

Garrett-Bodley commented 7 months ago

d7d6ac03bbc7e0d3a19dcd5359bd6167005251dd

Right now I'm just loading the samples directly from his github.io link. Is there a way to copy those files and serve them as part of Github pages? How did you serve the samples for sonic garbage?

gregsadetsky commented 7 months ago

Small note that it used to work on mobile but now I can't hear anything. Does it work on yours? Excited for react! Lmk if I can help

Garrett-Bodley commented 7 months ago

It works on my phone, but there's a significant delay. Instruments are implemented in an extremely hacky way rn. It reloads the samples every time you press the play button. Probably a network connection thing, maybe try waiting longer after pressing?

Garrett-Bodley commented 7 months ago

Oh also I turned the volume down for presentations. That might be part of it?

gregsadetsky commented 7 months ago

Yeah it does work now sorry. And you're right about the delay, I was also in a place w slowish mobile internet