I wanted to let you know what I had to update in v0.3.0 in order for us to merge to master:
jsDMR.R: I copied the version from annot_dev which had the latest update (fdr_dev had been merged to annot_dev). I added compatibility for both BED and BW files as input (basically based it off of your code from master). I got rid of field 'Last modified' since it was (again) inconsistent with Github's tracking system and thus very confusing. To avoid (potentially) serious issues, I found it necessary to remove it from (at least) code files.
jsGrank.R: copied from your last commit on master, and removed 'Last modified' field for the same reason as in 1.
Main README: I added v0.2.2 under 'Version History' section, like you had done on main README in master.
I don't think I am missing anything, but considering it's been two months since I last worried about this, I would say I am sure in probability, not a.s., so there is non-zero probability that something went over my head. If you can double check that R_src is in order before merging, I will feel more comfortable with the merge considering this is a new release, and then I will be sure a.s.. Also, I propose we get rid of all 'Last Modified' field everywhere. I have found it very confusing and potentially harmful while updating branch v0.3.0.
On another note, I am currently running a test on MARCC. If it goes well, then I think I will be happy with the merging if you are too after going over folder R_src in v0.3.0. Let me know if you want to GTM to discuss any of these points or go over it together, I am available right now.
Hey Garrett,
I wanted to let you know what I had to update in v0.3.0 in order for us to merge to master:
I don't think I am missing anything, but considering it's been two months since I last worried about this, I would say I am sure in probability, not a.s., so there is non-zero probability that something went over my head. If you can double check that R_src is in order before merging, I will feel more comfortable with the merge considering this is a new release, and then I will be sure a.s.. Also, I propose we get rid of all 'Last Modified' field everywhere. I have found it very confusing and potentially harmful while updating branch v0.3.0.
On another note, I am currently running a test on MARCC. If it goes well, then I think I will be happy with the merging if you are too after going over folder R_src in v0.3.0. Let me know if you want to GTM to discuss any of these points or go over it together, I am available right now.
Jordi