Garsondee / pf2e-roll-manager

A module for making group rolls easier in PF2E
MIT License
6 stars 5 forks source link

[Bug] DC Adjustment maths not mathing... #46

Open Truncated opened 2 weeks ago

Truncated commented 2 weeks ago

First, let me say that this mod idea and the execution concept you brought to the table is brilliant. Even with the quirkiness of the user interface in these first iterations, it's been super helpful getting my group feeling comfortable with Pathfinder 2e (we're all new to the system, though I've been running Pathfinder 1e since Alpha).

Obviously you're working things out and learning a ton and mistakes will be made... I just wanted you to know that we're impressed by your accomplishments already. This concept is fantastic and I think if you hammer out the User Experience this could easily be considered a must have mod for PF2e. Cheers, mate!


Okay, actually bug - the adjustment buttons from -10 to +10 don't math when you press more than one in what appears to be any combination. I can click -10, and it goes to 5 from 15. I could click +10 and it goes from 15 to 25. If I click +10, then -10... it goes from 15 to 25... to 5. :) All of the numbers seem to have this kind of double-count after the first button is clicked and it never corrects itself. Looks like something is getting double counted and stuck?

Garsondee commented 2 weeks ago

Thank you very much for your kind words and feedback - I really hope that this module will be helpful and with a bit of help from the community I'm hoping it'll continue to get better at working with the PF2E system. The interface needs a lot of work to be super quick to use but I'm very open to suggestions and plan to allow options for changing the way it works so that it works better for a wider range of GMs. Thank you for the bug report, it's a dumb bug but should be a very easy one to squash.

Truncated commented 2 weeks ago

@Garsondee Well, good sir, that's something I can help with! I'm a solution architect in my day job, so collaborating on the design and UX of things for programmers to make manifest IS something I can do. :)

Snapshot Here's a quick wireframe I threw together in Balsamiq. It's rough, but I think it covers some big ideas and current layout challenges.

Like I said, the central design approach you present is great - it's quick, graphic, and self-explanatory. I knew how to use it just by looking at it, from both the GM and Player sides. That's HUGE! Auto-closing the roll display that you introduced this past release nailed the only real pain point I had; the exit button was getting forgot by players and would cause it to get stuck if another roll request came through while it was still up...

The ambitiousness of the actions and search you included really inspired me as well, but this is a full vision concept that you're likely going to want to break apart into 3 or more milestones of functionality. Let me know if you have any questions! I am doing a bit more research before I tackle the follow the expert impacts, if any, to this.

Note: The Untrained --> Master buttons would all have the names on them. I got sloppy with it. :) Basically the idea is whatever adjustment "DC range increments" are being shown would have the name and number on each button. It would be more compact to leave just the number or just the word, but for me this is one of the key examples of how your design made it so accessible to me as a new GM. It's enough to help, but it really doesn't take up enough space where I'm mad at it being there as I get comfortable with it.

Maybe settings to hide the title / number down the road because not everyone will be happy, but as-is for defaults for sure imo.

Note 2: The All button toggles between Select all if 0 to all but one characters (N-1) are selected, and Clear All if all characters (N) is selected

Garsondee commented 1 week ago

Wow. This is amazing. The only slight alteration I'd make it that I want to only softly constrain the DC that can be set. PF2E is designed to work well with specific ranges of DCs but as a GM I occasionally throw a very easy DC at the group to check for that 5% of a Natural One occurring and occasionally I do the same for extremely unlikely things where only a Natural 20 would give them success. The important thing is to inform the GM about whether or not the roll is outside of the expected range without limiting them incase they are doing something unusual, or for shock value or due to some unusual homebrew.

I am considering adding the ability to 'simulate' the rolls (Foundry VTT supports dice simulation to work out the distribution of results) so that the GM can know at a glance the chance of various degrees of success. This would be optional as not all GMs want to know the mathematical odds but with this feature you'd be able to get an instant of idea of what you were setting your players up for.

I love the layout you've suggested and I'd like to work towards it in the long term. Do you know if there is a good library for developing UIs like that might work with Foundry VTT? Everything I've done so far has been a bodge of flex containers but for v3 of the UI it would make sense to use a better system entirely.

Thank you for your contribution! Very much appreciated!

Garsondee commented 1 week ago

https://github.com/Garsondee/pf2e-roll-manager/issues/51

I've moved discussion about the UI improvements to a new issue. I'll close this once I deal with the + / - buttons for the DC.