search

Garteal / MPDN_Extensions

Media Player .Net (MPDN) Open Source Extensions
Other
0 stars 0 forks source link

Add folders first #3

Closed Ryrynz closed 9 years ago

Ryrynz commented 9 years ago

ATM when files are added to the playlist via the add folder icon the files are sorted alphabetically regardless of whether they're in a directory or not. I'd like to see an option to add folders first (sorted alphabetically also) so it matches up with what's typically seen in Windows Explorer.

Garteal commented 9 years ago

Could you be a little more specific? I've added a folder (with a bunch of subfolders in them) and everything shows up perfectly with 1. Death Note/Death Note 01.mkv coming before Code Geass/Code Geass 01.mkv

Are you referring to having subfolders appearing first in the playlist and then the files in the actual folder?

Ryrynz commented 9 years ago

http://i.imgur.com/VL3PxlM.jpg

Notice how the folders view first in Explorer but are listed alphabetically in the playlist after having dragged this folder into it.

Garteal commented 9 years ago

Alright cool. Copied your structure since all of mine (organized) worked good. I'll try to get it fixed.

Garteal commented 9 years ago

Made some changes. It's not entirely what I want yet, but let me know if it does what you were thinking.

Ryrynz commented 9 years ago

Not quite right yet.

http://i.imgur.com/pbKuwDl.jpg

Folders are on now the bottom and 'The Gift' which was first as it should be is now last.

Garteal commented 9 years ago

I made some changes to this in the previous commit. It's actually how I want atm, but I'm not sure if it'll work properly in all cases yet. It's basically what you want, but in reverse. First it displays what's in the folders, then the subfolders' files get displayed.

Unfortunately sorting won't sort properly since it doesn't seem to work for some reason and I'll have to look into it further to get it fixed.

Ryrynz commented 9 years ago

As above with 'The Gift', if I add via the 'add files' icon then titles that start with ' are listed first. If I use the add directory icon those same files are last (just before the subfolders)

Sorting the subfolders to the top ain't a big deal for now, but the sorting should be consistent for the files at least.

Garteal commented 9 years ago

Just realized that's not a straight apostrophe. Using a straight apostrophe will place it right before The_Raven. If I'm not mistaken it's one of the ’ apostrophes. Using those places it first like in your screeny. Anyway working on fixing the issue, stay tuned!

Garteal commented 9 years ago

Could you do some testing here? Everything should be consistent and sorting properly (on directory first), with the exception of it being the reverse of your request.

Ryrynz commented 9 years ago

Yup, everything looked good here too, will do a final check tomorrow.

Ryrynz commented 9 years ago

No issues that I can see. There could be an option to display directories first in the general options if you wanted to add that.