Assertion failure saving while using relative path

Garux / netradiant-custom

The open-source, cross-platform level editor for id Tech based games.

https://garux.github.io/NRC/

Other

299 stars 52 forks source link

Assertion failure saving while using relative path #164

Open CansecoDev opened 5 months ago

CansecoDev commented 5 months ago

Using:

Windows 11 23H2
Latest Development build (Sep 20, 2023)

Description: Saving while using a relative path for the gamedata shows this error dialog, the map saves without any noticeable issue.

Reproduction steps:

On the Global preferences select Jedi Knight Jedi Academy.
Make sure the Engine Path is set to a relative path: ../../Academy/ for this case.
Save a map.

ensiform commented 5 months ago

This error probably shouldn't happen but I think the absolute path should be entered instead of relying on the relative path since it deals with passing off the path you give to other external tools.

Garux commented 5 months ago

I highly doubt that tools were built with relative engine path in mind. One obvious flaw shall be with CWD != binary folder. Can remove the assert, if everything else file dialog related works for you. Unsure what's the assert point was originally: Gtk file chooser requirement or guard user code from using non absolute path.