No icons when compiling in Windows with msys2

Garux / netradiant-custom

The open-source, cross-platform level editor for id Tech based games.

https://garux.github.io/NRC/

Other

316 stars 56 forks source link

No icons when compiling in Windows with msys2 #17

Closed Pipexlul closed 5 years ago

Pipexlul commented 5 years ago

Windows 10 just followed all instructions for Win32 - MSYS2 64 bit. The result is this: radiant_2018-11-06_16-48-10

The splash screen is also a missing icon, I checked and all the icon files are correctly placed under bitmaps/ folder but they don't display in the program.

wongit commented 5 years ago

I had the same issue a few months back and found replacing \msys64\mingw64\bin\libgdk_pixbuf-2.0-0.dll with the one included in the netradiant 64bit release fixed it.

Garux commented 5 years ago

Perhaps msys2 lib got borked or radiant is using deprecated function.
At least it was working with fresh msys2 libs year ago, got to recheck.

Pipexlul commented 5 years ago

Just confirmed @wongit 's solution. It is displaying all icons now.

Garux commented 5 years ago

Issue is totally legit, as new gdk-pixbuf is using optional external modules, changed script copies them too.