search

Garux / netradiant-custom

The open-source, cross-platform level editor for id Tech based games.
https://garux.github.io/NRC/
Other
300 stars 52 forks source link

cleanup l_net #204

Open Vorschreibung opened 1 week ago

Vorschreibung commented 1 week ago

Various cleanups for l_net.

This also fixes a standing issue that these UDP sockets were never closed and each build invocation accumulated lingering unconnected UDP sockets.

Vorschreibung commented 1 week ago

Ready to review :blush:, to verify:

grep WINS_MyAddress . -r
grep Net_MyAddress . -r

Tested on Linux.

Garux commented 1 week ago

Added some tweaks, want to know your opinion.

Vorschreibung commented 6 days ago

Added some tweaks, want to know your opinion.

Good catch! I've dug deeper and it turns out that broadcastaddr as well was not needed, turns out the whole broadcasting over UDP was just used to get one's own IP address.

I've followed this trail and continued removing even more functions that were all unused now: https://github.com/Garux/netradiant-custom/pull/204/commits/cb54f917786c74606706881197609f25f442e908#diff-be9a2b010ddc8f46a80d007c0c991216faf0a3501574d938afb1f65e1d9b34d3

I've also noticed that the 2 l_net_wins implementations (windows and posix) are mostly identical now and thus have merged them into one with ifdefs: https://github.com/Garux/netradiant-custom/pull/204/commits/7fa6c48bf556b173e3d422e9182db2b7f5d8cd3d

Please let me know if you think this is a good approach.

@Garux while I was careful with the changes, I have verified and tested only under Linux, if you can test under Windows I would appreciate, otherwise please tell me and I'll test on Windows myself