Garux / netradiant-custom

The open-source, cross-platform level editor for id Tech based games.
https://garux.github.io/NRC/
Other
299 stars 52 forks source link

Wrong common shaders used / game configuration ignored #64

Closed Spaghetti657 closed 3 years ago

Spaghetti657 commented 3 years ago

Some games (e.g. Jedi Academy) do not use textures/common for core editor shaders and instead use textures/system. This is properly defined in the .game configuration, but netradiant ignores this and always assumes the common path for certain operations (automatic caulking, applying trigger when creating a trigger, possibly others but those are what I am aware of). image

Secondly, it would be nice to be able to turn off the automatic application of the trigger shader on entity creation (for cases where the mapper wants to use a custom one), just like there is an option to turn off automatic caulking.

Garux commented 3 years ago

.game cfg definitely works here image Off option is not very necessary i think, as the mapper will apply custom texture, as he would do with the option. One improvement there may be using .game common_shaders_dir="common/" in GetCommonShader() as a fallback before using hardcoded path to simplify configuration.

Spaghetti657 commented 3 years ago

The ja.game does not have a shader_trigger entry so that would explain it. Using the configured shaders directory would be a welcome change though.

Garux commented 3 years ago

Addressed this image