search

Garux / netradiant-custom

The open-source, cross-platform level editor for id Tech based games.
https://garux.github.io/NRC/
Other
334 stars 59 forks source link

Edges mode not fully deactivating, resulting in deformed brushes. #65

Open MaceMadunusus opened 3 years ago

MaceMadunusus commented 3 years ago

Immediately after deactivating Edges mode after having modified a brush, Edges mode stays active until after a second click, resulting in brushes continuing to change shape and sometimes deforming into bad shapes. If this is an intended feature, an option to turn it off would be appreciated.

https://user-images.githubusercontent.com/3003653/110163077-37950e00-7db5-11eb-8b61-4c0f43ee5572.mp4 (Netradiant brush deformation error/behavior)

https://user-images.githubusercontent.com/3003653/110163084-3a8ffe80-7db5-11eb-9382-abd56cd7b7e5.mp4 (GTK Radiant 1.6 behavior)

https://user-images.githubusercontent.com/3003653/110163090-3d8aef00-7db5-11eb-8253-d515d51081dd.mp4 (Requiring a second click to drag both faces as normal)

Garux commented 3 years ago

This is not exactly feature, but it appears to be usable. You can select components in various component modes and manipulate them at once or merge. Sorta allows advanced tricks. Quitting component mode via double deselect bind hit avoids the problem, while using component mode toggle allows advanced scenario.

Spaghetti657 commented 3 years ago

It would be nice to have an option to disable that behavior (so selection is cleared when changing modes) as it can feel unexpected, and adds an extra key press to some basic workflows where you do not need to do anything advanced.

Alternately, maybe add a reselect function? Could be useful generally, but in this case you could have the default behavior clear selection on mode change, and then anyone wanting to do tricks could reselect.

Garux commented 3 years ago

Adding options has downside: it may become hard to find needed one among them :) This is one of those situations, when it's not possible to get both of the bananas gracefully. Probably should just do deselection, at least for vertices and edges potential uses are nuff exotic. Faces are usable for extrusion though. Need to consider all possibilities fairly well. As for basic workflow, it's actually way simpler, alt+m1 does components editing immediately in default tool mode.

Spaghetti657 commented 3 years ago

Clearing on edges/vertices seems like a reasonable compromise. Thank you for pointing out alt+m1 though, as that is even fewer keystrokes than toggling select mode.

I will make a separate feature request for a reselect feature though as it seems like that would just be a nice to have regardless of this.