search

GarwelGarwel / Celsius

RimWorld mod adding realistic thermodynamics
4 stars 7 forks source link

Add German translation #32

Closed ntninja closed 1 year ago

ntninja commented 1 year ago

Missing some critical bits that are hard-coded / not exposed as Keyed attributes (incomplete internationalization). I also added some extra temperature units were they make sense and used ³ instead of ^3. Spent some time yesterday on reading up on thermodynamics terms used, so I’m pretty confident I got the german jargon terms correct now (got some them wrong at first of course :slightly_smiling_face:).

GarwelGarwel commented 1 year ago

Thank you for this PR. A few comments:

  1. Can you make it target dev branch instead of master? I try to only push released changes into master.
  2. Celsius no longer refers to Joules, because many materials have very different thermal properties from what they have in real life.
  3. There have been some changes in the localizations files (e.g. switch from Conductivity stat to Insulation, addition of new settings), which should be propagated to other localizations. But I guess it can be updated later.
GarwelGarwel commented 1 year ago

Ok, I'll try to fix it myself. But the translation will be slightly outdated on release.

GarwelGarwel commented 1 year ago

And can you let me know which parts are not exposed as attributes? I might have missed a few lines, but it wasn't the intention.