GaryA / antlog

AntLog event management for AWS-style double-elimination competitions
Other
2 stars 1 forks source link

Merge feature requested in #76 - JSON fights feed #90

Closed cjsoftuk closed 6 years ago

cjsoftuk commented 6 years ago

This PR merges the JSON fights feed branch into master - adding a new endpoint /fights/json

The endpoint /fights/json must be passed a query string parameter eventId to tell it which event to show the feed for.

A future PR will add support for an empty eventId selecting the first event that is running on that date.

Closes garya/antlog#76.

cjsoftuk commented 6 years ago

Thanks for the Feedback - am new to Yii - so wasn't entirely sure on the best way to do some of this.

Will look at getting these changes addressed.

I hadn't even noticed the unnecessary file creation......

GaryA commented 6 years ago

This feature has been implemented separately, so this pull request will not be merged.