search

GaryOderNichts / recovery_menu

Recovery Menu for the Nintendo Wii U
GNU General Public License v2.0
144 stars 17 forks source link

Rewrite LED handler. #20

Closed V10lator closed 11 months ago

V10lator commented 1 year ago

This allows for setting a duration which will be needed in further PRs. It also changes NOTIF_LED into a usable enum, changes how elements are defined and adds new ones for purple.

GaryOderNichts commented 1 year ago

Hmm, not quite a fan of creating a new thread every time the LED needs to be updated.

V10lator commented 1 year ago

The thread is created when a delay is passed to the function only so it switches back to the old state after said delay. How to implement such a delay without a new thread?

filipe-maia commented 1 year ago

Just adding this issue here, because seems to be related: https://github.com/GaryOderNichts/recovery_menu/issues/18

GaryOderNichts commented 1 year ago

@V10lator Can you test the implementation I made in feature/led_handler and refactor your two other PRs on top of it, if it works as expected?

GaryOderNichts commented 11 months ago

The other PRs have now been implemented on top of feature/led_handler.