search

GaryStanton / phaser3-merged-input

A Phaser 3 plugin to map input from keyboard & gamepad to player actions
MIT License
34 stars 5 forks source link

Add install and typescript to README #19

Closed bbugh closed 2 years ago

bbugh commented 2 years ago

I was looking for a plugin like this and just came across it moments ago, how fortuitous for me that TypeScript was just merged with #16 a couple of hours ago! It's working great so far.

I couldn't find a way to make this work without TypeScript complaining about types, and found a thread about a different plugin which was helpful.

I added some instructions to the README for installation and for usage with TypeScript.

@zewa666 maybe you want to take a look too in case I missed something?

zewa666 commented 2 years ago

oh thats a good point. wasnt thinking about it @bbugh as I'm so used to TypeScript shenanigans but certainly helpful as a quickstart

bbugh commented 2 years ago

I made the recommended change and clarified the usage with TypeScript. I also fixed the example code formatting, I noticed that the tab stop is 4 in the readme, so the new example code I added is also 4 now.

GaryStanton commented 2 years ago

Thank you both so much for taking the time to work on this. Sorry I'm not so quick at merging pull requests, but I can't tell you how much I appreciate you spending time on the project.