Add output block config

GasDet-Bonn / tpx3-daq

Timepix3 DAQ

GNU General Public License v3.0

6 stars 2 forks source link

Add output block config #21

Closed magruber closed 6 years ago

themperek commented 6 years ago

Can we have a better name than write_outputBlock_config? Also for getGlobalSyncHeader?

magruber commented 6 years ago

Do you have any suggestions? Maybe we could change write_outputBlock_config to write_outputBlock. But I think getGlobalSyncHeader fits best for its purpose.

Vindaar commented 6 years ago

Just a short note, will take a closer look later: While I prefer camelCase anyways, since we decided to follow Python's PEP, the outputBlock should be written as output_block I fear. :/

Vindaar commented 6 years ago

Besides the two comments, this looks very good. About the name, I'm not sure either. For a start we should stick to snake_case everywhere I guess (that also includes getGobalSyncHeader of course (which I find a reasonable name for what it is).

I can do the refactoring of the read config functions.