GasolSun36 / ToG

[ICLR 2024] Think-on-Graph: Deep and Responsible Reasoning of Large Language Model on Knowledge Graph
155 stars 13 forks source link

Some bugs while reimplement #16

Open Pangjing-Wu opened 6 months ago

Pangjing-Wu commented 6 months ago

Hi, I found some bug while reimplement ToG:

GasolSun36 commented 6 months ago

Hi Steve,

Thanks for being interested in our ToG! However, I've been too busy lately to check the entries one by one, so you can just pull requests to the repo. Best, Jiashuo Sun

Original Email

Sender:"Steve Wu"< @.*** >;

Sent Time:2024/4/17 19:48

To:"GasolSun36/ToG"< @.*** >;

Cc recipient:"Subscribed"< @.*** >;

Subject:[GasolSun36/ToG] Some bugs while reimplement (Issue #16)

Hi, I found some bug while reimplement ToG:

./ToG/utils.py line 155: there is a typo of missing underline between “pre” and “head”

./ToG/README.md lines 12 and 23: duplicated argument name, I think the duplicated one should be temperature_reasoning.

./ToG/prompt_list.py lines 14 and 20: typo, it should be Entities instead of Entites. Does it affect LLM’s performance?

./ToG/utils.py lines 105-110: why the code called llama server when ”llama" not in engine.lower()? I think it should call GPT 3.5-turbo in this situation.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>