GateNLP / gate-core

The GATE Embedded core API and GATE Developer application
GNU Lesser General Public License v3.0
75 stars 29 forks source link

EmptyVisitor still refers to ASM5 #160

Closed ianroberts closed 1 year ago

ianroberts commented 1 year ago

gate-asm has been updated to ASM version 9, but the EmptyVisitor class that we use as the base for our visitors still uses the ASM5 opcodes definition. This means that the visitor still fails when asked to process classes that use newer features, see https://groups.io/g/gate-users/message/1156 for an example.

Fixing this is not necessarily as simple as switching the opcodes to ASM9 when calling the superclass constructors, we need to audit that we're not using any methods that are deprecated in v9 and adjust accordingly.