search

GateNLP / gate-core

The GATE Embedded core API and GATE Developer application
GNU Lesser General Public License v3.0
75 stars 29 forks source link

We Need A Way To Blacklist Plugins #89

Open greenwoodma opened 5 years ago

greenwoodma commented 5 years ago

Twitter 8.6 no longer works properly (logic errors rather than exceptions) with GATE 8.7-SNAPSHOT or above but there is no way of flagging that to users. It would be nice to have a list of blacklisted plugins to prevent such issues. Probably a file like the metadata fils that list versions known not to work

johann-petrak commented 3 years ago

So if a plugin version about to be loaded is found on the blacklist, what would we want to happen? Throw an exception? Just logging a warning might be easy to overlook in some cases. Maybe throw an exception unless a property or environment variable is set to deliberately override? Do we want to notice when a blacklisted version wants to get loaded after another non-listed version already has been loaded because then the working version would still get used, right?

greenwoodma commented 3 years ago

I'd want to make it impossible to load the plugin at all. It either wouldn't show up or would be an error in the plugin manager and so not manually loadable. If you tried to load an app that referenced it I'd want that to throw an exception and stop (just as if the plugin didn't exist) probably with a message to use the xgapp upgrade tool to move to a new version.